Is anyone having the issue with Error 504?

thammaporn · August 18, 2018, 3:36am

Is anyone having the issue with 504 Gateway time-out or Is it just my network on the server?
This doesn’t happened in localhost on my pc.

I have get this error when requested the page through Token Authentication(after /login ).
My project is running on Nginx and I tried to config the proxy server but it doesn’t work.

Much appreciated if anyone can share how to fix the problem.

omaralbeik · August 23, 2018, 6:20pm

I’m having the exact same problem with Vapor and nginx

/api/users/ (ok)
/api/users/id (504 error)

It works on localhost though

thammaporn · August 26, 2018, 6:25am

Hello @omaralbeik ,

After I rechecked my api both on localhost at my pc and Nginx on the cloud server.
For my case, It work properly.

But When I protect with CSRF tokens in Chapter 20 “Web Authentication” below code . For my case ,It happened “504” only on the cloud server ,but not on the localhost at my pc .

let protectedRoutes = authSessionRouters.grouped(RedirectMiddleware(path:“/login”))
protectedRoutes.get(“acronyms”,“create”,use: createAcronymHandler)

So far I tried to debug from Nginx log file . But still don’t catch any cause .

omaralbeik · August 26, 2018, 6:51am

In my case, I had a User object that owns Todo children, and I use Token auth.
the problem is getting a Todo by its id is working only on localhost, but not Nginx
After a few hours of debugging, I fixed it by getting the children from the authenticated user and query over them.

This works:

github.com

omaralbeik/VaporTodos-API/blob/93484d2b7d17989ff881a5f117ebe9911845cde6/Sources/App/Controllers/TodoController.swift#L43


      
          
          
	func createHandler(_ req: Request) throws -> Future<Todo.Public> {
          		let user = try req.requireAuthenticated(User.self)
          		return try req.content.decode(Todo.CreateRequest.self).flatMap { todo in
          			let todo = try Todo(title: todo.title, isDone: false, userId: user.requireID())
          			try todo.validate()
          			return todo.save(on: req).public
          		}
          	}
          
          
	func getHandler(_ req: Request) throws -> Future<Todo.Public> {
          		let user = try req.requireAuthenticated(User.self)
          		guard let todoId = req.parameters.values.first.flatMap({ Int($0.value) }) else {
          			throw Abort(.badRequest)
          		}
          
          
		return try user.children.query(on: req).filter(\.id == todoId).first().map(to: Todo.self) { possibleTodo in
          			guard let todo = possibleTodo else {
          				throw Abort(.notFound)
          			}
          			return todo

This does not:

github.com

omaralbeik/VaporTodos-API/blob/fa628deddbf52ebd7d601a895765fe3794e9483e/Sources/App/Controllers/TodoController.swift#L26


      
          		tokenAuthGroup.get(use: getAllHandler)
          		tokenAuthGroup.put(Todo.parameter, use: updateHandler)
          		tokenAuthGroup.delete(Todo.parameter, use: deleteHandler)
          	}
          
          
}
          
          
// MARK: - Handlers
          private extension TodoController {
          
          
	func getHandler(_ req: Request) throws -> Future<Todo.Public> {
          		let userId = try req.requireAuthenticated(User.self).requireID()
          		return try req.parameters.next(Todo.self).map(to: Todo.Public.self) { todo in
          			guard todo.userId == userId else {
          				throw Abort(.notFound)
          			}
          			return todo.public
          		}
          	}
          
          
	func getAllHandler(_ req: Request) throws -> Future<[Todo.Public]> {

Still, I have no idea why this is the case

0xtim · August 29, 2018, 3:05pm

Is Nginx definitely forwarding the authentication headers?

thammaporn · September 1, 2018, 2:30pm

@0xtim

Hello ,
Did you mean forward “Bearer Token” to proxy header?
My Nginx.conf is look like below.
Very appreciated if you could share about how to add the authentication header into the Sever block .

try_files $uri @proxy;
location @proxy {
proxy_set_header HOST $host;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_set_header X-Real-IP $remote_addr;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_pass http://localhost:8080;
proxy_redirect http:// https://;

…

shogunkaramazov · September 1, 2018, 2:44pm

@0xtim Can you please help with this when you get a chance? Thank you - much appreciated! :]

thammaporn · September 18, 2018, 7:03pm

After I run command " update vapor " then rebuild the project.
There are no issue regarding the error 504 .

Thanks vapor team to fix the problem.

shogunkaramazov · September 18, 2018, 9:03pm

@thammaporn Thank you for sharing the solution - much appreciated!

axlroach · September 26, 2018, 4:06pm

Hi all – Sorry, I think I’m missing something here. What was the solution to this issue? I’m having exactly the same problem. Is there an nginx config I need to change?

I have in my boot router:

let tokenAuthGroup = userRoutes.grouped(tokenAuthMiddleware, guardAuthMiddleware)

tokenAuthGroup.get(use: list)
tokenAuthGroup.get(User.parameter, use: get)

both work locally on my mac, but only list works on the server behind nginx.

The get function is:

func get(_ req: Request) throws → Future<User.Public> {
return try req.parameters.next(User.self).convertToPublic()
}

Thanks so much!

axlroach · September 27, 2018, 7:44am

Sorry, I wasn’t following the ‘update vapor’ comment from before. I ran ‘vapor update -y’ and that seems to have fixed the issue. FYI - I initially had an error when attempting the update, so I removed the Package.resolved file and then removed the .build directory. Then ‘vapor update -y’ ran with no error. I then reissued ‘swift build -c release’ and restarted my vapor app.

Hope this helps someone.

Thanks all!