# Atomics - Incremental kernel thread counter

**URL:** <https://forums.kodeco.com/t/atomics-incremental-kernel-thread-counter/136120>\
**Category:** Metal by Tutorials\
**Created:** [March 25, 2021, 3:43pm UTC](https://forums.kodeco.com/t/atomics-incremental-kernel-thread-counter/136120 "2021-03-25T15:43:08Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![quaternionboy](https://assets.chunter.kodeco.com/user_avatar/forums.kodeco.com/quaternionboy/32/110937_2.png) [@quaternionboy](https://forums.kodeco.com/u/quaternionboy)\
**Post date:** [March 25, 2021, 3:43pm UTC](https://forums.kodeco.com/t/atomics-incremental-kernel-thread-counter/136120/1 "2021-03-25T15:43:08Z")

</div>

Hi there!

Let’s say that I want to increment a property `var incremental:Int32` every time a kernel thread is executed:

```
//SWIFT
var incremental:Int32 = 0
var incrementalBuffer:MTLBuffer!
var incrementalPointer: UnsafeMutablePointer<Int32>!

init(metalView: MTKView) {
    ...
    incrementalBuffer = Renderer.device.makeBuffer(bytes: &incremental, length: MemoryLayout<Int32>.stride)
    incrementalPointer = incrementalBuffer.contents().bindMemory(to: Int32.self, capacity: 1)
}
func draw(in view: MTKView) {
    ...
    computeCommandEncoder.setComputePipelineState(computePipelineState)
    let width = computePipelineState.threadExecutionWidth
    let threadsPerGroup = MTLSizeMake(width, 1, 1)
    let threadsPerGrid = MTLSizeMake(10, 1, 1)
    computeCommandEncoder.setBuffer(incrementalBuffer, offset: 0, index: 0)
    computeCommandEncoder.dispatchThreads(threadsPerGrid, threadsPerThreadgroup: threadsPerGroup)
    computeCommandEncoder.endEncoding()
    commandBufferCompute.commit()
    commandBufferCompute.waitUntilCompleted()
    
    print(incrementalPointer.pointee)
}

//METAL
kernel void compute_shader (device int& incremental [[buffer(0)]]){
    incremental++;
}

```

So I expect outputs:

```
10
20
30
 ...

```

but I get:

```
1
2
3
...

```

> **[GitHub - quaternionboy/Atomic](https://github.com/quaternionboy/Atomic)**
>
> Contribute to quaternionboy/Atomic development by creating an account on GitHub.

---

<div class="post-metadata">

**Author:** ![quaternionboy](https://assets.chunter.kodeco.com/user_avatar/forums.kodeco.com/quaternionboy/32/110937_2.png) [@quaternionboy](https://forums.kodeco.com/u/quaternionboy)\
**Post date:** [April 1, 2021, 2:41pm UTC](https://forums.kodeco.com/t/atomics-incremental-kernel-thread-counter/136120/2 "2021-04-01T14:41:05Z")

</div>

As you suggest @caroline

```
kernel void compute_shader (device atomic_int& incremental [[buffer(0)]]){
    atomic_fetch_add_explicit(&incremental, 1, memory_order_relaxed);
}

```

Solves the issue!! But if I try to optimise it:

```
[[kernel]] void compute_shader (device atomic_int& incremental [[buffer(0)]],
                                ushort lid [[thread_position_in_threadgroup]] ){
    
    threadgroup atomic_int local_atomic {0}; 
    
    atomic_fetch_add_explicit(&local_atomic, 1, memory_order_relaxed);
    
    threadgroup_barrier(mem_flags::mem_threadgroup);
    
    if(lid == 0) {
        int local_non_atomic = atomic_load_explicit(&local_atomic, memory_order_relaxed);
        atomic_fetch_add_explicit(&incremental, local_non_atomic, memory_order_relaxed);
    }
}

```

Expect:

```
10
20
30
...

```

Get:

```
1125974026
1125974036
-2000908258
-832823256 ...

```

> **[GitHub - quaternionboy/Atomic](https://github.com/quaternionboy/Atomic)**
>
> Contribute to quaternionboy/Atomic development by creating an account on GitHub.

---

<div class="post-metadata">

**Author:** ![caroline](https://assets.chunter.kodeco.com/user_avatar/forums.kodeco.com/caroline/32/111867_2.png) [@caroline](https://forums.kodeco.com/u/caroline)\
**Post date:** [April 5, 2021, 4:49am UTC](https://forums.kodeco.com/t/atomics-incremental-kernel-thread-counter/136120/3 "2021-04-05T04:49:06Z")

</div>

I fear this is above my pay grade, and I don’t see how you can be expecting `10, 20, 30` from the result.

However if you replace

```auto
threadgroup atomic_int local_atomic {0}; 

```

with:

```auto
threadgroup atomic_int local_atomic;
atomic_store_explicit(&local_atomic, 0, metal::memory_order_relaxed);

```

then you get `1, 2, 3...`

---

<div class="post-metadata">

**Author:** ![quaternionboy](https://assets.chunter.kodeco.com/user_avatar/forums.kodeco.com/quaternionboy/32/110937_2.png) [@quaternionboy](https://forums.kodeco.com/u/quaternionboy)\
**Post date:** [April 6, 2021, 6:28am UTC](https://forums.kodeco.com/t/atomics-incremental-kernel-thread-counter/136120/4 "2021-04-06T06:28:56Z")

</div>

Thank you very much @caroline,

The issue was initialise local threadgroup var when declared as you pointed.

In this way works fine:

```
threadgroup atomic_int local_atomic;
if (lid == 0) atomic_store_explicit(&local_atomic, 0, memory_order_relaxed);

```

I’m adding 1 for each thread in the threadgroup to the local variable and when all threads of the threadgroup are done (barrier) add the local to the increment.
